Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Allowance Module] More info about resetBaseMin #11

Closed
dasanra opened this issue Aug 13, 2020 · 0 comments · Fixed by #10
Closed

[Allowance Module] More info about resetBaseMin #11

dasanra opened this issue Aug 13, 2020 · 0 comments · Fixed by #10

Comments

@dasanra
Copy link

dasanra commented Aug 13, 2020

The setAllowance function is easy to understand but is not that clear the use case for resetBaseMin

https://github.com/gnosis/safe-modules/blob/72ab62dde6651133f3670000ef14bd87d24bc3cb/allowances/contracts/AlowanceModule.sol#L69

Add an explanation about resetBaseMin can be used to set allowance reset to be at a desired time of day/week...
@rmeissner rmeissner changed the title More info about resetBaseMin [Allowance Module] More info about resetBaseMin Oct 1, 2020
@rmeissner rmeissner mentioned this issue Oct 1, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allowances modules (aka Withdrawal Limit) safe-global/safe-modules
1 participant
@dasanra