Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3406 testing option of crash due to subtraction overflow #3421

Merged
merged 2 commits into from
May 31, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3406

Changes proposed in this pull request:

  • Avoid overflow on subtraction

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 8.25%. Comparing base (fb255a5) to head (76753a7).
Report is 1 commits behind head on main.

Files Patch % Lines
...Management/KeystoneOwnerKey/KeystoneSignFlow.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3421      +/-   ##
========================================
- Coverage   8.25%   8.25%   -0.01%     
========================================
  Files        788     788              
  Lines      44211   44214       +3     
========================================
  Hits        3648    3648              
- Misses     40563   40566       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit a6be08e into main May 31, 2024
2 of 4 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3406/crash-fix-2 branch May 31, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant