Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2482 smoke test for the networks (chains in the CGW) #3394

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #2482

Changes proposed in this pull request:

  • Adding a test for the chains endpoint on the app side

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 809 lines in your changes are missing coverage. Please review.

Comparison is base (2b3ddf0) 8.14% compared to head (f9999b0) 8.27%.
Report is 36 commits behind head on main.

Files Patch % Lines
...Connect to Web/Logic/WebConnectionController.swift 0.00% 234 Missing ⚠️
...sViewController/TransactionDetailCellBuilder.swift 0.00% 102 Missing ⚠️
Multisig/Logic/Models/EIP712Transformer.swift 0.00% 70 Missing ⚠️
...cureConfig/Sources/SecureConfig/SecureConfig.swift 0.00% 59 Missing ⚠️
... Web/Logic/WebConnectionToSessionTransformer.swift 0.00% 49 Missing ⚠️
...ntroller/ReviewSafeTransactionViewController.swift 0.00% 49 Missing ⚠️
...Connect to Web/Logic/WebConnectionRepository.swift 0.00% 44 Missing ⚠️
...isig/UI/WalletConnectV2/WalletConnectManager.swift 48.05% 40 Missing ⚠️
...let/UI/SendTransactionToWalletViewController.swift 0.00% 19 Missing ⚠️
...isig/Cross-layer/Configuration/Configuration.swift 0.00% 17 Missing ⚠️
... and 24 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3394      +/-   ##
========================================
+ Coverage   8.14%   8.27%   +0.13%     
========================================
  Files        786     789       +3     
  Lines      43371   44064     +693     
========================================
+ Hits        3532    3647     +115     
- Misses     39839   40417     +578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 19c1eeb into main Feb 8, 2024
5 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-2482/integration-test-for-chains branch February 8, 2024 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant