Function signature mismatch for isValidSignature()

[shoenseiwaso]

The signature for isValidSignature() in contracts/interfaces/ISignatureValidator.sol mismatches with the one in contracts/handler/CompatibilityFallbackHandler.sol. Compilation fails with solc v0.8.16 (and probably others).

TypeError: Data locations of parameters have to be the same when overriding non-external functions, but they differ.
  --> contracts/handler/CompatibilityFallbackHandler.sol:28:5:
   |
28 |     function isValidSignature(bytes calldata _data, bytes calldata _signature) public view override returns (bytes4) {
   |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Overridden function is here:
  --> contracts/interfaces/ISignatureValidator.sol:19:5:
   |
19 |     function isValidSignature(bytes memory _data, bytes memory _signature) public view virtual returns (bytes4);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

One fix is to simply update the interface to match the implementation (i.e. memory ==> calldata).

[rmeissner]

Already tracked here #394

[mmv08]

fixed by #394