Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check EIP-165 signature of Guard before adding #309

Closed
rmeissner opened this issue May 6, 2021 · 1 comment
Closed

Check EIP-165 signature of Guard before adding #309

rmeissner opened this issue May 6, 2021 · 1 comment
Assignees
@mmv08
Milestone
Version 1.4.0

Comments

@rmeissner
Copy link
Member

Currently we trust that the address set via setGuard can handle the hooks. If this is not the case the only way to "unstuck" the Safe is to have a module registered that can revert this.

To minimize the risk of this happening we could check that the target address supports the Guard interface with an EIP-165 check.
@rmeissner
Copy link
Member Author

Close with #310

@rmeissner rmeissner added this to the Version 1.4.0 milestone Dec 16, 2022
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#309 from safe-global/fix-safetxgas
920dfeb 
fix: Handle 0 safeTxGas when passed to createTransaction call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmv08 mmv08

Labels
None yet
Projects
None yet
Milestone
Version 1.4.0
Development

No branches or pull requests
2 participants
@rmeissner @mmv08