-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send msg.sender along to fallback handler #246
Milestone
Comments
We should add a notice that this functionality should only be relied on in the fallback habdler with contracts that are of version 1.3.0 or newer. It might make sense to add a check for this in the HandlerContext contract |
rmeissner
added a commit
that referenced
this issue
Mar 24, 2021
This was referenced Mar 24, 2021
rmeissner
added a commit
that referenced
this issue
Mar 24, 2021
Uxio0
pushed a commit
that referenced
this issue
May 6, 2021
Uxio0
pushed a commit
that referenced
this issue
May 6, 2021
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this issue
Nov 1, 2023
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this issue
Nov 1, 2023
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this issue
Jan 14, 2024
…able Make signTransaction method immutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the fallback handler doesn't have any way to detect what contract triggered it.
A similar approach to what GSN is doing can be used (e.g. appending msg.sender to the data).
The fallback handler then can extract the msg.sender (e.g. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/solc-0.8/contracts/GSN/GSNRecipient.sol#L217)
The text was updated successfully, but these errors were encountered: