Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1155 required EIP-165 support #161

Closed
rmeissner opened this issue Dec 12, 2019 · 0 comments · Fixed by #285
Closed

EIP-1155 required EIP-165 support #161

rmeissner opened this issue Dec 12, 2019 · 0 comments · Fixed by #285
Milestone
contracts-safe-1.3.0

Comments

@rmeissner
Copy link
Member

EIP-1155 states:

Smart contracts MUST implement the ERC-165 supportsInterface function and signify support for the ERC1155TokenReceiver interface to accept transfers. See "ERC1155TokenReceiver ERC-165 rules" for further detail.

Therefore we should add EIP-165 support to the DefaultFallbackHandler.

This is not critical right now, as the Gnosis implementation and the OpenZeppelin implementation of EIP-1155 do not make use of EIP-165. This can be added at a later point in time with an update to the DefaultFallbackHandler.
@rmeissner rmeissner modified the milestone: contracts-safe-1.2.0 Apr 10, 2020
@rmeissner rmeissner added this to the contracts-safe-1.3.0 milestone Jan 18, 2021
rmeissner added a commit that referenced this issue Mar 24, 2021
@rmeissner
Closes #161: Add EIP-165 support in DefaultCallbackHandler
83e5e1b
@rmeissner rmeissner mentioned this issue Mar 24, 2021
Merged
rmeissner added a commit that referenced this issue Mar 24, 2021
@rmeissner
Closes #161: Add EIP-165 support in DefaultCallbackHandler (#285)
b4ac134
Uxio0 pushed a commit that referenced this issue May 6, 2021
@rmeissner @Uxio0
Closes #161: Add EIP-165 support in DefaultCallbackHandler (#285)
3a7c5b8
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
@rmeissner
Closes safe-global#161: Add EIP-165 support in DefaultCallbackHandler (…
b225b09 
…safe-global#285)
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#161 from gnosis/add-origin
0a03d0a 
Add `origin` property to `proposeTransaction()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
contracts-safe-1.3.0
Development

Successfully merging a pull request may close this issue.

Closes #161: Add EIP-165 support in DefaultCallbackHandler safe-global/safe-smart-account
1 participant
@rmeissner