Bug: Fix network type in safe info #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
rmeissner
approved these changes
Dec 18, 2020
Merged
mmv08
added a commit
that referenced
this pull request
May 13, 2021
Bug: Fix network type in safe info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating safe-react-apps I stumbled upon a bug where the return value of the network was in uppercase but the type was in lowercase
https://github.com/gnosis/safe-react/blob/0ecd70fdbcd94952ce82acd00dbfbaaaa4ec1f74/src/config/index.ts#L18
https://github.com/gnosis/safe-react/blob/0ecd70fdbcd94952ce82acd00dbfbaaaa4ec1f74/src/config/networks/network.d.ts
This PR fixes that by changing the type from lowercase to uppercase (faster than updating the interface and there's no real need to return the lowercase one)