feat: support workspace dependencies #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saecki
reviewed
Sep 16, 2022
There was a problem hiding this comment.
Interesting! Apart from the little suggestion I left I think this is good to go.
Leaving this more as a reminder for myself:
We could add a workspace flag to the Section record, and then parse the target and kind anyway so we can add diagnostics for invalid workspace dependencies. Also a lint for optional workspace dependencies (that are not allowed) would be a nice to have.
jwong101
force-pushed
the
feat/workspace-dependencies
branch
from
fa51abd
to
eddd6c2
Compare
jwong101
force-pushed
the
feat/workspace-dependencies
branch
from
eddd6c2
to
1fc17ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace inheritance was recently stabilized and will be included in the
1.64release on Sep 22 2022.This PR simply treats the
[workspace.dependencies]table as a default table, since it previously were treated as an invalid dependency section. Per the RFC, only regulardependenciesare supported in the[workspace]table.