Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): support public labels #452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kubernetes): support public labels #452

wants to merge 1 commit into from

Conversation

acouvreur
Copy link
Member

closes #449

@acouvreur acouvreur linked an issue Nov 17, 2024 that may be closed by this pull request
(Kubernetes) labels not public #449
Open
@github-actions github-actions bot added documentation Improvements or additions to documentation provider Issue related to a provider reverse-proxy Reverse proxy integration related issue labels Nov 17, 2024
sftim
sftim reviewed Nov 18, 2024
View reviewed changes
Copy link

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acouvreur
Copy link
Member Author

LGTM

There's an issue with a nil pointer, I have to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation provider Issue related to a provider reverse-proxy Reverse proxy integration related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Kubernetes) labels not public
2 participants
@acouvreur @sftim