Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PRBTest with native Foundry assertions #842

Closed
PaulRBerg opened this issue Mar 12, 2024 · 6 comments
Closed

Replace PRBTest with native Foundry assertions #842

PaulRBerg opened this issue Mar 12, 2024 · 6 comments
Assignees
@smol-ninja
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Mar 12, 2024 •
edited
Loading

Forge Std v1.8.0 has been released recently.

It comes with a wonderful new feature: native Foundry assertions! They got rid of DSTest.

This has motivated me to deprecate PRBTest, hence why I also opened this issue here to replace PRBTest with the native assertions available in Foundry now.

Related:
@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Mar 12, 2024
@PaulRBerg PaulRBerg mentioned this issue Mar 12, 2024
Closed
@smol-ninja smol-ninja self-assigned this Mar 12, 2024
@andreivladbrg
Copy link
Member

andreivladbrg commented Mar 14, 2024 •
edited
Loading

This has motivated me to PaulRBerg/prb-test#45

so, it means one less dep?

this issue requires to update the forge-std lib, thus more changes would be needed (just saying)

@PaulRBerg
Copy link
Member Author

it means one less dep?

Yeah

@smol-ninja
Copy link
Member

We would also have to replace PRBTest with native Foundry's StdAssertions in prb-math as a requirement to this.

@PaulRBerg
Copy link
Member Author

I'm OK with that.

@smol-ninja
Copy link
Member

I have created a PR (#222) to update forge-std in prb-math.

@PaulRBerg
Copy link
Member Author

Thanks for that, reviewed it now.

This was referenced Mar 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @andreivladbrg