Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove scoped style data attributes in feed #520

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

krmax44
Copy link
Contributor

@krmax44 krmax44 commented Oct 9, 2019

Summary

Before:

<content type="html"><![CDATA[<p data-v-6875e4c8>Lorem ipsum...</p>]]></content>

After:

<content type="html"><![CDATA[<p>Lorem ipsum...</p>]]></content>

Not needed for RSS feeds, just removes the extra clutter.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for saber ready!

Built with commit 4eb445c

https://deploy-preview-520--saber.netlify.com

@egoist
Copy link
Collaborator

egoist commented Oct 9, 2019

Maybe add this as an option: renderPageContent(link, { scope: boolean }) 🤔 and make it false by default.

@egoist egoist changed the title chore: remove scoped style data attributes in feed fix: remove scoped style data attributes in feed Oct 10, 2019
@egoist egoist merged commit 17e29dc into saberland:master Oct 10, 2019
@krmax44 krmax44 deleted the chore/scoped-styles-rss branch October 10, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants