feat: Add saber eject-theme command

[krmax44]

Summary

Closes #247

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #247: Add theme eject command
• #247: Add theme eject command

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[netlify]

Deploy preview for saber ready!

Built with commit 5eac002

https://deploy-preview-259--saber.netlify.com

[krmax44]

There's one thing still missing: the file copying works well, but the config does not yet get altered. To add this, the script needs to know where the layout, components etc. files are located, which is not the same for every theme. I came up with a couple of potential solutions:

• Every theme needs to declare main (or some other custom key) in its package.json, which points to a Saber configuration, related: Support saber config in theme directory #160
• The script or theme loader should look for the path containing the layouts subdirectory (or a Saber configuration, whatever is a clear sign that this is the theme's root folder). Might be problematic in cases where a dist and source folder both containing a layout folder or other more exotic folder structures.
• Enforce a strict folder structure every theme needs to use
• Check for folders like dist and src, partially already present but only for npm themes:

saber/packages/saber/lib/index.js

Lines 140 to 144 in 9caaf74

	if (/node_modules/.test(this.theme)) {
	const distDir = path.join(this.theme, 'dist')
	if (fs.existsSync(distDir)) {
	this.theme = distDir
	}

What do you think? @saberland/core

[nblthree]

I prefer using main in package.json.
The reason why I prefer using main is because it's the simplest solution and it's easy to implement for you and for the theme developer. also

The script or theme loader should look for the path containing the layouts subdirectory (or a Saber configuration, whatever is a clear sign that this is the theme's root folder). Might be problematic in cases where a dist and source folder both containing a layout folder or other more exotic folder structures.

This isn't a perfect solution and it can fail in some cases.

Enforce a strict folder structure every theme needs to use

This is annoying for the theme developers.

Check for folders like dist and src, partially already present but only for npm themes

I just don't like this one (Not flexible)

[krmax44]

@egoist your opinion on this?

[egoist]

the file copying works well, but the config does not yet get altered

what config?

[krmax44]

@egoist saber-config.yml

[egoist]

we forgot monorepo 😄 https://github.com/saberland/create-portfolio/tree/master/packages/saber-theme-portfolio

[krmax44]

IIRC, package.json allows specifying something like repository.pathTo, which we could use for this.

[krmax44]

Added monorepo support and dependency merging. Only thing missing is that saber-config.yml doesn't get updated accordingly, reasons above. Will need to wait for #160

[krmax44]

Okay, I tested it now with portfolio and tailsaw, and it works great so far! What do you think @egoist?