fix: Scroll to anchor not working #213

[krmax44]

Summary

Fixes #213.

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

[netlify]

Deploy preview for saber ready!

Built with commit 5c2ba51

https://deploy-preview-214--saber.netlify.com

[egoist]

Let's remove

saber/website/src/mixins/doc.js

Line 5 in d778282

'$route.hash': {

then

[krmax44]

I just noticed a couple of changes missing in my PR. I'll push them tomorrow.

[egoist]

Another thing needs to fixed: trigger scroll on the initial load, currently we only trigger scroll after route navigation.

[krmax44]

Exactly, that change didn't go through. I'll push that later.

[krmax44]

So it works under Firefox but not Chrome 🤔 https://5ced00ce5e1c320008959c62--saber.netlify.com/tutorial/tutorial.html#prerequisites

[kidonng]

So it works under Firefox but not Chrome 🤔 5ced00ce5e1c320008959c62--saber.netlify.com/tutorial/tutorial.html#prerequisites

FYI, it works on (old) Edge. So blame Chromium😢

[krmax44]

See https://deploy-preview-214--saber.netlify.com/docs#fn1 nicely scrolls to where it's supposed to go 😄