Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pen buttons on Android #859

Open
xx1182 opened this issue Jul 28, 2023 · 13 comments · May be fixed by #1355
Open

Pen buttons on Android #859

xx1182 opened this issue Jul 28, 2023 · 13 comments · May be fixed by #1355
Labels
bug Something isn't working

Comments

@xx1182
Copy link

xx1182 commented Jul 28, 2023

Describe the bug

A button on the pen, it's usually for erasing, or whatever you set it.

To reproduce

  1. Open the app
  2. Start a new note or whiteboard
  3. Draw
  4. Press the button on the pen

Expected behavior

When you press the button, it should select the eraser or hilghliter tool; relase the button, and 6oure back to pen input.

Saber version

v0.14.11 Google Play (14110)

Device

  • Device: Samsung Galaxy Fold 4
  • OS: Android 13

Anything else?

Great app, but please record yourself drawing with a pencil on paper and add it as an additional option to hear the brushing. Otherwise, responsive, still great!

@xx1182 xx1182 added the bug Something isn't working label Jul 28, 2023
@Iey4iej3
Copy link

SPen button should work to some extent, and now it is working as an eraser, although there are some minor issues: #797 (comment)

@xx1182
Copy link
Author

xx1182 commented Jul 29, 2023

SPen button should work to some extent, and now it is working as an eraser, although there are some minor issues: #797 (comment)

Mine doesn't, probably because isn't the "powered one"(the pro version which uses Bluetooth or the ones inside the Note series), it's the fold one.
It works to some extent like you said, it gets recognised as a pen so don't have to use the "draw with finger", but the physical button doesn't work, nothing happens

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Jul 30, 2023

Did you try to touch the screen by the pen, and while holding the pen on the screen tap the button on the pen? It's not good UX, but it should work (toggle eraser). Saber waits for better pen support by Flutter. For now, we need to wait, too, and hope the stylus support will come early.

@xx1182
Copy link
Author

xx1182 commented Jul 30, 2023

No, did not try it and infact works as you say.

Is there any plan to support "pixel eraser", erases around a radius?
Regards.

@srghma
Copy link

srghma commented Aug 13, 2023

Did you try to touch the screen by the pen, and while holding the pen on the screen tap the button on the pen

Works

@adil192
Copy link
Member

adil192 commented Aug 17, 2023

Is there any plan to support "pixel eraser", erases around a radius? Regards.

It's not currently a high priority issue, see #40.

@djibux
Copy link

djibux commented Sep 26, 2023

Same issue as OP, with a Samsung Galaxy S6 lite. Pen is also not powered.

Did you try to touch the screen by the pen, and while holding the pen on the screen tap the button on the pen

Indeed that works: the pen needs to be touching the screen. Hovering is not enough.

@Iey4iej3
Copy link

Iey4iej3 commented Oct 4, 2023

Indeed that works: the pen needs to be touching the screen. Hovering is not enough.

This is a (very old) bug of flutter: flutter/flutter#42846

I guess that it might help if you react there.

@shayan15sa
Copy link

Hey guys wanted let you know erasing with spen button works on Android 14
I just uptaded my tab s6 lite to android 14 now.It didn't used to work when I was on Android 13 but now it works fine.

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Mar 13, 2024

It looks working for me, too. It still has it's own troubles (isn't so responsive like erasing in e.g. Samsung Notes), but it's way better than it used to be.

@Microwave-WYB
Copy link

Hey guys wanted let you know erasing with spen button works on Android 14 I just uptaded my tab s6 lite to android 14 now.It didn't used to work when I was on Android 13 but now it works fine.

How did you managed to update Tab S6 Lite to Android 14? I don't even receive Android 14 update on my S7+

@shayan15sa
Copy link

Hey guys wanted let you know erasing with spen button works on Android 14 I just uptaded my tab s6 lite to android 14 now.It didn't used to work when I was on Android 13 but now it works fine.

How did you managed to update Tab S6 Lite to Android 14? I don't even receive Android 14 update on my S7+

Hi
I have the newer model (tab s6 lite 2022). I think that's why. There are some unofficial ram too.

@3akev 3akev linked a pull request Sep 19, 2024 that will close this issue
@Robin-Sch
Copy link

Robin-Sch commented Nov 13, 2024

For me, whenever I press the button and then touch a non-drawn part of the screen, it will undo the last action. So, whenever I want to erase something I need to be very precise or else it'll undo the last thing instead of erasing. Is it possible to disable this?
As a workaround, I figured out that when hovering above the screen, pressing and releasing button and then touching the screen will always erase and not undo, but this is quite inconvenient and requires precise timings. I do not care about the undo feature and whenever I press the button I just want to erase, is it possible to change this, somehow?
Edit: this was a bug and has been fixed already: #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants