Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eraser: size and preview #408

Open
Polux49 opened this issue Feb 24, 2023 · 5 comments
Open

Eraser: size and preview #408

Polux49 opened this issue Feb 24, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Polux49
Copy link
Contributor

Polux49 commented Feb 24, 2023

Is your feature request related to a problem? Please describe.
When erasing small objects, quite often it happens that I erase other objects in the neighborhood.

Describe the solution you'd like

  1. Possibility to change the size of the eraser.
  2. Preview it (for example, like in gimp, by a dashed circle around the pointer).
@Polux49 Polux49 added the enhancement New feature or request label Feb 24, 2023
@ceskyDJ
Copy link
Contributor

ceskyDJ commented Feb 25, 2023

I agree, this is a good point 👍🏻.

@Luciogi
Copy link

Luciogi commented Feb 26, 2023

it can be related to delete selection #170

@m0byn
Copy link

m0byn commented May 23, 2023

I use the zoom feature intensively to fit more content on to one page. In more detail, I zoom to 4x or so, write some content with smallest pen size selected. Then, I zoom out and have a good overview of all the content on one page. The problem happens when I am trying to erase some parts because the eraser covers a predefined and not adjustable area. So, in the case of erasing the area covered by the eraser is just too big and most of the time too much is erased. So, I would recommend to set the eraser size proportionally to the zoom level. I would think of something like eraser area divided by zoom level, or so.

Also, previewing the eraser area would be very helpful!!

Keep up the good work!!

@ceskyDJ
Copy link
Contributor

ceskyDJ commented May 23, 2023

I think @Luciogi want resizing as used by the pen/pencil tool. Would it be good enough for you? I think it will be much simpler for implementation (it is already implemented for pen/pencil tool...). It's up to @adil192, of course, but if you have some preference, feel free to post it here ;).

@m0byn
Copy link

m0byn commented May 24, 2023

I think the one option does not exclude the other. Resizing as used by the pen/pencil tool is of course a good starting point. An improvement would be making to set the desired size, and then adjust it automatically depending on the zoom level. Otherwise you would need to resize the eraser every time you change the zoom level. So I think both would be very convenient. However, as a starting point just manual resizing and preview of the area would be very nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants