Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boottest() thows no error for fixest models with varying slopes fixed effects #126

Closed
s3alfisc opened this issue Jul 2, 2023 · 0 comments · Fixed by #114
Closed

boottest() thows no error for fixest models with varying slopes fixed effects #126

s3alfisc opened this issue Jul 2, 2023 · 0 comments · Fixed by #114

Comments

@s3alfisc
Copy link
Owner

s3alfisc commented Jul 2, 2023

E.g. for models as

feols(Y ~X | var1[var2])

boottest does not throw an error when no cluster variable is specified.

Instead, it continues to control for ~var1 + var2 as fixed effects.

If a cluster variable is specified, the following error pops up:

library(fixest)
library(fwildclusterboot)
packageVersion("fwildclusterboot")

base = iris
names(base) = c("y", paste0("x", 1:3), "fe1")
# Create another "fixed-effect"
base$fe2 = rep(letters[1:5], 30)
head(base)

est_vs = feols(y ~ x1 | fe2[[x2]], base, cluster = "fe1")
# Error in fe2[[x2]] : 
#   attempt to select more than one element in vectorIndex

Hence not as critical as I had feared - only the heteroskedastic bootstrap is affected - but still not great.

@s3alfisc s3alfisc linked a pull request Jul 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant