From bf3d28929c0978b38f3f6b14b7945b93111e6177 Mon Sep 17 00:00:00 2001 From: Alexander Fischer Date: Sun, 1 Aug 2021 18:31:00 +0200 Subject: [PATCH] further cran submission error fixes related to suggests & vignette --- cran-comments.md | 7 ++++++- vignettes/fwildclusterboot.Rmd | 6 +++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index d1cd1bd0..e2bfd453 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,6 +1,11 @@ +## Version 0.3.6 submission, Resubmission 2 + ++ Another error due to "noSuggests" / vignette - package fixest was used, but not loaded + + ## Version 0.3.6 submission, Resubmission -+ Adressed errors related to suggestsdescribed below (reason for error; unprotected library(lfe) statements in tests) ++ Adressed errors related to suggests described below (reason for error; unprotected library(lfe) statements in tests) + noSuggests error due to missing library("pkg") statements in vignette + lfe now install on ubuntu dev diff --git a/vignettes/fwildclusterboot.Rmd b/vignettes/fwildclusterboot.Rmd index 1b79a8c7..4abaa67d 100644 --- a/vignettes/fwildclusterboot.Rmd +++ b/vignettes/fwildclusterboot.Rmd @@ -234,9 +234,9 @@ If regression weights are specified in the estimation stage via `lm()`, `feols() ```{r} # regression with weights / WLS -lm_w_fit <- feols(proposition_vote ~ treatment + ideology1 + log_income, weights = voters$weights, data = voters) +lm_w_fit <- lm(proposition_vote ~ treatment + ideology1 + log_income, weights = voters$weights, data = voters) -boot_feols <- boottest(lm_w_fit, +boot_w_lm <- boottest(lm_w_fit, clustid = "group_id1", param = "treatment", B = 9999) @@ -250,7 +250,7 @@ A major bottleneck for the performance of `boottest()` is a large matrix multipl The number of threads can be specified via the `nthreads` argument of `boottest()`: ```{r, eval = FALSE} -boot_feols <- boottest(lm_fit, +boot_lm <- boottest(lm_fit, clustid = "group_id1", param = "treatment", B = 9999,