Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing Dependency Install with pip #148

Closed
Deech08 opened this issue Aug 22, 2020 · 0 comments · Fixed by #157
Closed

[BUG] Missing Dependency Install with pip #148

Deech08 opened this issue Aug 22, 2020 · 0 comments · Fixed by #157

Comments

@Deech08
Copy link

Deech08 commented Aug 22, 2020

As part of JOSS Review openjournals/joss-reviews#2554

h5py not installed when running pip install desk

Looking at the setup.py it seems like its missing from the install requires field, along with some other packages that are listed as requirements in requirements.txt

Error is encountered when running desk grid following install in a new conda environment

Error message:

(desk_rev_pip) Dhaneshs-MacBook-Pro-2:DESK_TEST dk$ desk grids
Traceback (most recent call last):
File "/anaconda3/envs/desk_rev_pip/bin/desk", line 5, in
from desk.main import main
File "/anaconda3/envs/desk_rev_pip/lib/python3.8/site-packages/desk/main.py", line 5, in
from desk import console_commands
File "/anaconda3/envs/desk_rev_pip/lib/python3.8/site-packages/desk/console_commands.py", line 8, in
from desk.set_up import (
File "/anaconda3/envs/desk_rev_pip/lib/python3.8/site-packages/desk/set_up/get_models.py", line 6, in
import h5py
ModuleNotFoundError: No module named 'h5py'

Conda environment details:
new environment with python 3.8, then run only pip install desk

Edit: Additional packages are also missing and should be added
-matplotlib, sklearn,

@s-goldman s-goldman linked a pull request Sep 8, 2020 that will close this issue
@s-goldman s-goldman linked a pull request Sep 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant