Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Requirements #147

Closed
Deech08 opened this issue Aug 22, 2020 · 0 comments · Fixed by #156
Closed

[Feature Request] Requirements #147

Deech08 opened this issue Aug 22, 2020 · 0 comments · Fixed by #156

Comments

@Deech08
Copy link

Deech08 commented Aug 22, 2020

As part of JOSS Review openjournals/joss-reviews#2554

While not a requirement, i think it would be useful to include the package requirements/dependencies (like astropy, seaborn, etc.) explicitly in the readme and documentation. Most useful would be on the "installation" page/section just so users will know what to expect pip to install if they don't already have it.

If you prefer not to for any reason, that's fine as well as its not a technical requirement with JOSS (since you have the package pip installable and a requirements.txt file exists).

@s-goldman s-goldman linked a pull request Sep 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant