Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert lib-3rd-party/dynamic-contrast.js to typescript #85

Open
silverneko opened this issue Feb 2, 2023 · 0 comments
Open

Convert lib-3rd-party/dynamic-contrast.js to typescript #85

silverneko opened this issue Feb 2, 2023 · 0 comments

Comments

@silverneko
Copy link

Hi,

First of all, thanks for this awesome extension!

I'm working on porting this extension to our in house editor. My company, Google, has a editor based on the web-based vscode. I'm currently having some difficulties because this extension have a mixture of .js and .ts source. Our build system doesn't like that and I'm having a hard time integrating the code.

Instead of fiddling with our build system and hack around the issues, I'd like to just rewrite the entire lib-3rd-party/dynamic-contrast.js to .ts, as that would make the codebase of this extension purely typescript.

For me, this change would make integrating this project with our repository simpler.
For you, this change shouldn't have any meaningful affect, other than added type safety as dynamic-contrast would now be properly typed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant