Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airhumidifier_miot.py - mapping attribute error #911

Closed
tierman opened this issue Jan 13, 2021 · 4 comments
Closed

airhumidifier_miot.py - mapping attribute error #911

tierman opened this issue Jan 13, 2021 · 4 comments
Labels

Comments

@tierman
Copy link

tierman commented Jan 13, 2021

Hi,
now i get error like: AttributeError: 'AirHumidifierMiotStatus' object has no attribute 'fault'.

To resolve it, please change in airhumidifier_miot.py:
line 83 from def error(self) -> int: to def fault(self) -> int:
line 231 from self.error to self.fault
line 210 from "<AirHumidifierMiotStatus" to "<AirHumidifierMiotStatus " <- only space.

Best regards
Tomek.

@tierman tierman added the bug label Jan 13, 2021
@rytilahti
Copy link
Owner

This got fixed in #909 earlier today, thanks for reporting though :-)

@syssi syssi reopened this Jan 13, 2021
@syssi
Copy link
Collaborator

syssi commented Jan 13, 2021

The issue looks like a follow-up. @tierman this library doesn't access AirHumidifierMiotStatus.fault anywhre. We are calling the property AirHumidifierMiotStatus.error. Which implementation expects the fault property?

@tierman
Copy link
Author

tierman commented Jan 17, 2021

@syssi This is my fault. I tried to use Yours library with https://github.com/develop-dvs/domoticz-AirHumidifier2. But there are many problems with new Xiaomi airhumidifier and domoticz library. One of them seemed to be a bug in yours library - but doesn't.
Now i try to write domoticz plugin to cooperate with xiaomi airhumidifier using your lib.

I am a Java developer and new to Python. Sorry for my incorrect issue report.

@syssi
Copy link
Collaborator

syssi commented Jan 17, 2021

No problem! Good luck!

@syssi syssi closed this as completed Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants