Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Jackson even tho it is only used in one extension method #115

Closed
dtropanets opened this issue Jun 24, 2019 · 7 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dtropanets
Copy link
Contributor

Hey. I've noticed that there is a dependency on Jackson. Is it really that necessary to add it to the library just to use it inside of one extension method? Can it be possibly moved to a separate artifact?

@rybalkinsd
Copy link
Owner

@dtropanets that's a good point. I was also thinking about it some times ago.
Are you satisfied with the default configuration of defaultHttpClient?

Just in case, did you get any Jackson version conflicts while using?

Potentially, it's possible to move default client configuration feature to the separate artifact.

@rybalkinsd rybalkinsd added enhancement New feature or request good first issue Good for newcomers labels Jul 1, 2019
@rybalkinsd
Copy link
Owner

As for the current vision:

  • we should keep ResponseBody.asJson() ext function, however, provided by a specific artifact:
    • kohttp-fastjson
    • kohttp-jackson
    • kohttp-moshi
  • yaml configuration for default client should be implemented as a separate module
    • kohttp-config

@rybalkinsd
Copy link
Owner

@dtropanets do you have any further suggestions according to the vision

@rybalkinsd
Copy link
Owner

@gokulchandra You previously get in touch with json within the project. Would you be interested in PoC design for this feature?

@dtropanets
Copy link
Contributor Author

@rybalkinsd We had to use custom client in order to use proxy, so can't tell much about the default one. Regarding the Jackson, I excluded all Jackson modules from dependency after we've noticed that it is included in 0.9.0. Don't remember having any issues. Also, can't tell much about yaml config, since I won't be able to use it, since I have to dynamically build the client in order to apply the proxy values received from the build machine (we use kohttp exclusively for CI scripts).

@rybalkinsd
Copy link
Owner

Closing this issue due to #128 plan

@rybalkinsd
Copy link
Owner

@dtropanets Thanks for the details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants