add keybind for going to previous/next page

[RiedleroD]

should be quite simple to do & adds a hell of a lot of usability to folks like me who like using the keyboard for navigation.

Also see this related PR I made for peppercarrot for reference. Note that I completely overengineered the input parser. Don't do that maybe.

Also note that framagit went down between me writing this and hitting send. what the fuck.

[ryanvilbrandt]

Great idea! This would be an excellent feature that I think people would love.

Notes for this feature for myself for later:

• This change will need to be configurable in the comic_info.ini file.
• Default on or off? Probably off, to prevent confusion.
• Individual keybinds as well as the feature as a whole should be configurable.
  • Look into other possible keybinds as well.
• Tooltips on the navigation buttons, only if the keybinds are enabled.
• Implementation detail: The config options will need to be passed in as a global value to the Jinja2 template (maybe as a dict?) and then passed from the template in to the Javascript file as it's initialized.
• Will need documentation added to the wiki for the feature, probably just in the comic_info.ini page.

[RiedleroD]

okay, no offense, I'm just going to say this: you're overengineering it.

For every bulletpoint you made, consider this: do you actually have enough time to implement it? Will anyone actually care? I don't think anyone would want to turn that off or have different keybinds (save for vim controls maybe)

I suggest saving your breath and implementing this as simply as possible while leaving room for future improvements like turning it off, tooltips, or even other controls like jumping to the first/last page with, idk, Ctrl held or something. Build features gradually, see if anyone cares, and save potentially wasted time.

except for docs. docs are important.

again, no offense intended. I'm just seeing a large potential problem here & trying to help.

On another note, if your website isn't too complex to setup (what is jinja?) I might try opening a PR tomorrow to implement this myself. Don't hold your breath though, I can quickly drop my excitement for something when it doesn't work how I want it to. Only time will tell.