Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window size issues with dpi in development branch #289

Closed
kevinw opened this issue Jul 12, 2018 · 3 comments
Closed

window size issues with dpi in development branch #289

kevinw opened this issue Jul 12, 2018 · 3 comments
Labels
bug Some API breaks the contract it establishes subsystem-graphics

Comments

@kevinw
Copy link

kevinw commented Jul 12, 2018

On the development branch, the window size is broken on my Windows 10 setup.

Creating a 100x100 window results in a 150x150px window with a 100x100 viewport:

image

I see that glutin now has LogicalSize and PhysicalSize types, and expects the LogicalSize variant in its WindowBuilder. src/graphics/window.rs and maybe also src/graphics/resize.rs probably needs to be made aware.

@kevinw
Copy link
Author

kevinw commented Jul 12, 2018

Also for the record, the events.get_primary_monitor().get_hdpi_factor() function returns 1.5 in my setup.

@ryanisaacg ryanisaacg added bug Some API breaks the contract it establishes subsystem-graphics platform-win32 labels Jul 12, 2018
@ryanisaacg
Copy link
Owner

Thanks for the report!

I'll look into this, I don't have any issues with DPI on macOS, but I've never used Windows with a DPI factor other than 1.

@kevinw
Copy link
Author

kevinw commented Jul 13, 2018

Looks great, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Some API breaks the contract it establishes subsystem-graphics
Projects
None yet
Development

No branches or pull requests

2 participants