Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Loop for Mojave and Catalina #7

Open
ZJPat opened this issue Feb 7, 2020 · 1 comment
Open

Add a Loop for Mojave and Catalina #7

ZJPat opened this issue Feb 7, 2020 · 1 comment

Comments

@ZJPat
Copy link

ZJPat commented Feb 7, 2020

Hello Since Catalina moved System Preferences to /system, can you please add a loop to check if its 10.14 or below to add System Preferences from Applications otherwise add it from /system/Applications.

Thanks

@jfiliceatcsumb
Copy link

jfiliceatcsumb commented May 2, 2020

I think it would be simpler to add logic to dockbuilder.sh at around lines 38 and 38 to check for the existence of $item before adding the dock item. It would enable us to have lists both the Catalina paths and the pre-Catalina paths; dockbuilder would only try to add the "correct" paths and skip items that do not exist.

if [ -e "$item" ]; then
/usr/local/bin/dockutil --add "$item" ...
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants