Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react router apply middleware peer dependency #5

Open
perrin4869 opened this issue Jul 16, 2016 · 2 comments
Open

Remove react router apply middleware peer dependency #5

perrin4869 opened this issue Jul 16, 2016 · 2 comments

Comments

@perrin4869
Copy link

Now that react-router ships with applyRouterMiddleware by default, maybe the peer dependency to react-router-apply-middleware should be removed?

@perrin4869
Copy link
Author

hm... I see that the code here is not built to work as a react-router middleware... I could send a PR to change that

@jaimemarijke
Copy link

I'm also running into a problem here - I'm using the applyRouterMiddleware function included with react-router by default to add the useScroll middleware. However, the useRelativeLinks middleware doesn't seem to work unless I use the applyRouterMiddleware function from react-router-apply-middleware. Any plans to consolidate the two?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants