Support Base64 JWT secrets #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auth0 generates JWTs signed by a key that is a Base64- encoded binary blob (witness the "secret base64 encoded" checkbox at jwt.io). This patch adds support for such secrets while preserving the status quo by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth0 generates JWTs signed by a key that is a Base64-encoded binary blob (witness the "secret base64 encoded" checkbox at jwt.io). This patch adds support for such secrets while preserving the status quo by default.
I believe this patch is necessary: decoding the secret provided by Base64 and attempting to use it in its raw form is a non-starter: round-tripping it through UTF-8, as would be necessary using
curlin a terminal to pass these secrets to Kong APIs, will perturb the byte stream and lead to spurious signature mismatches.