Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of get_deltanums() is wrong #1

Open
assarbad opened this issue Dec 11, 2014 · 1 comment
Open

Implementation of get_deltanums() is wrong #1

assarbad opened this issue Dec 11, 2014 · 1 comment

Comments

@assarbad
Copy link

Presumably a relic from the evolution of the code, the implementation line should read:

return [d for d in self._deltas.keys()]

I noticed you're not using this function elsewhere in the module or the code, so that's the likely reason why this went unnoticed.

@assarbad
Copy link
Author

In addition the KeyError line in get_delta() should be:

raise ValueError('Delta %s does not exist.' % deltanum)

(note the argument to the format string)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant