Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Worker Support #32

Open
paynecodes opened this issue Aug 8, 2024 · 3 comments
Open

Node Worker Support #32

paynecodes opened this issue Aug 8, 2024 · 3 comments

Comments

@paynecodes
Copy link

I don’t see any mention on node’s worker_threads support. Is there any support planned?

@rxliuli
Copy link
Owner

rxliuli commented Aug 8, 2024

Waiting for upstream vite implementation, check vitejs/vite#3932

@paynecodes
Copy link
Author

paynecodes commented Aug 8, 2024

Waiting for upstream vite implementation, check vitejs/vite#3932

Thanks for referencing vitejs/vite#3932. It doesn't appear there is likely to be movement on that PR for a few reasons:

  1. it's from 2021 - no new commits since 2021
  2. nice-to-have label

I see your comment here: vitejs/vite#3932 (comment) where you reference electron-vite's worker plugin.

I actually tried that worker plugin as well as electron-vite's modulePath plugin before arriving at your repo. As I'm not too familiar with vite plugin development, I was unable to get them working in serve mode, but they do work in build mode.

@rxliuli
Copy link
Owner

rxliuli commented Aug 8, 2024

I actually tried that worker plugin as well as electron-vite's modulePath plugin before arriving at your repo. As I'm not too familiar with vite plugin development, I was unable to get them working in serve mode, but they do work in build mode.

I'm not sure what you mean by 'serve' mode. Do you perhaps have a GitHub repo I could look at? I could try to quickly write a vite plugin to test it out. I've previously written a rollup plugin as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants