Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vars.Fetch should take only var key to resolve value #274

Open
Chaitanyabsprip opened this issue Nov 21, 2024 · 3 comments
Open

vars.Fetch should take only var key to resolve value #274

Chaitanyabsprip opened this issue Nov 21, 2024 · 3 comments

Comments

@Chaitanyabsprip
Copy link
Contributor

No description provided.

@rwxrob
Copy link
Owner

rwxrob commented Nov 21, 2024

I woke up with the idea of adding the vars.Driver to bonzai again and actually triggering persistence from Set and hinting at it with Var.Persist. Let me try that.

@rwxrob
Copy link
Owner

rwxrob commented Nov 22, 2024

I am warming up to the idea of having both bonzai.Persistence and Cmd.WithPersistence() as well. I feel like if we do this right the only thing command developers would ever need would be Cmd.Vars and Cmd.Set/Get. All the other stuff is just external tools for dealing with specific bonzai.Persister implementations. In fact, I really want this because I can create a cloud-based persister for stuff I want to be able to use all over and leave the other stuff to localized things. Sounds like you like it as well. I'll go for it during my next mini-sprint (probably tonight).

@Chaitanyabsprip
Copy link
Contributor Author

You're right, I like it as well, I just have a question about the scope of the Persister, see #275 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants