Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Path Error on windows #15

Closed
Tastaturtaste opened this issue Jun 30, 2021 · 3 comments
Closed

Long Path Error on windows #15

Tastaturtaste opened this issue Jun 30, 2021 · 3 comments

Comments

@Tastaturtaste
Copy link

When syncing files with moodle on windows an error occurs because the path is longer than 260 characters. Presumably this restriction was added because of windows maximum path length limitation when using unprefixed paths.
Since both the windows api and qt support long path names with up to 32767 characters this seems like a pretty arbitrary restriction which hopefully can be lifted by appending _\?_ to the download path according to the documentation of windows max path length limitations.
This would prevent a very common error nearly everyone using windows currently encounters.
As I understand it the required change would be to delete the current manual check for the path length on windows and maybe prepend the above mentioned prefix to the download path.

Source for windows max path length limitations
Source for qt support for long path names

@Tastaturtaste
Copy link
Author

This issue was also reported on the old repository:
RobertKrajewski#162

A different fix was proposed, requiring checking for a registry key which enables long path names by default without the prefix. This is available only on windows >= 10 update 1607.
My proposed fix would probably work for older systems as well, but checking the flag and enabling long paths only for modern systems would probably be good enough for the majority of students.

@t-schroeder
Copy link
Collaborator

This should be fixed with the 2.4.5 release.

@Tastaturtaste
Copy link
Author

It is, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants