From 4727af35b3bda6de2f89eaabf54a87193703d8a3 Mon Sep 17 00:00:00 2001 From: David Thulke Date: Thu, 26 Jan 2023 17:44:36 +0100 Subject: [PATCH] memory_allocation_type in SimpleLinuxUtilityForResourceManagementEngine now default to PER_NODE --- CHANGELOG.md | 4 ++++ .../simple_linux_utility_for_resource_management_engine.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e8961a8..9f2de78 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- The memory_allocation_type in the slurm engine now default to per_node instead of per_cpu for consistency with other engines + ### Added - Support for async workflow definitions. If await tk.async_run(obj) is called sisyphus will wait until all Path objects inside of obj are available - Path has now is_set method diff --git a/sisyphus/simple_linux_utility_for_resource_management_engine.py b/sisyphus/simple_linux_utility_for_resource_management_engine.py index 2dc3fd6..b4f4956 100644 --- a/sisyphus/simple_linux_utility_for_resource_management_engine.py +++ b/sisyphus/simple_linux_utility_for_resource_management_engine.py @@ -45,7 +45,7 @@ class MemoryAllocationType(Enum): PER_NODE = "per_node" def __init__(self, default_rqmt, gateway=None, has_memory_resource=True, auto_clean_eqw=True, - ignore_jobs=[], memory_allocation_type=MemoryAllocationType.PER_CPU): + ignore_jobs=[], memory_allocation_type=MemoryAllocationType.PER_NODE): """ :param dict default_rqmt: dictionary with the default rqmts