Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nn.dropout should have axis mandatory #77

Closed
albertz opened this issue Nov 11, 2021 · 2 comments
Closed

nn.dropout should have axis mandatory #77

albertz opened this issue Nov 11, 2021 · 2 comments
Milestone

Comments

@albertz
Copy link
Member

albertz commented Nov 11, 2021

Related: #69, #76

@albertz
Copy link
Member Author

albertz commented Dec 22, 2021

I'm not so sure anymore. Using the feature dim is very standard for dropout.

You might argue that we never should use this concept of default feature dim. However, it is used in many places, even e.g. nn.Linear (#75). Also, as it was discussed before (rwth-i6/returnn#586 (comment)), maybe having a feature dim is actually not too much a problem. Except for those rare cases where it can become ambiguous but then we should just require those to be non-ambiguous.

But this discussion does not really belong here but to #17 instead.

I just say, if we make use in some places, e.g. also nn.Linear, then it should be ok here as well.

(@Zettelkasten opinions maybe?)

@albertz
Copy link
Member Author

albertz commented Dec 22, 2021

Well, actually I think we should just make it mandatory anyway. Done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant