Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eval function private, or rename it? #64

Closed
albertz opened this issue Nov 5, 2021 · 1 comment
Closed

Make eval function private, or rename it? #64

albertz opened this issue Nov 5, 2021 · 1 comment
Assignees
Milestone

Comments

@albertz
Copy link
Member

albertz commented Nov 5, 2021

Similar argument as #63. I think there should be nothing why this would ever be needed.

Although I can see that we have some legacy code (e.g. SpecAugment) which we might want to wrap initially, where we would need it.

And also, whenever we call external code, sth like this would be needed. Although for someone unfamiliar with RETURNN, eval is maybe confusing for this, and sth like wrap_external_function or so makes more sense?

@albertz
Copy link
Member Author

albertz commented Dec 22, 2021

This is done now.

@albertz albertz closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants