Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubnetworkLayer: deprecate from with concat_sources=False #531

Open
albertz opened this issue May 25, 2021 · 1 comment
Open

SubnetworkLayer: deprecate from with concat_sources=False #531

albertz opened this issue May 25, 2021 · 1 comment
Labels
potential-new-behavior Discussions about RETURNN behaviour TensorFlow

Comments

@albertz
Copy link
Member

albertz commented May 25, 2021

I think this depends on #530.

In case of concat_sources=False, the source names data:0 etc are not nice, and I think we can have better ways (this is #530).

(I'm not sure if we should also deprecate from for concat_sources=True, or if this is fine.)
This was referenced May 25, 2021
Open
Closed
@albertz albertz added the potential-new-behavior Discussions about RETURNN behaviour label May 25, 2021
@albertz
Copy link
Member Author

albertz commented May 25, 2021

Actually, not sure if the old behavior should be completely disallowed (so it needs a new behavior_version #508) or just deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
potential-new-behavior Discussions about RETURNN behaviour TensorFlow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertz @JackTemaki