You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the C extension module is installed (Levenshtein) this computation will be blazing fast and compatible with different platforms. Currently, how CharacTER is written with a precompiled SO, this is not the case.
Making the change suggested above will lead to better compatibility with close to zero performance loss due to the C implementation in Levenshtein. In fact, the whole EditDistance class seems unnecessary as pre_score can be replaced by a single line:
I tested this with a large corpus and results were always the same as the current implementation.
The text was updated successfully, but these errors were encountered:
BramVanroy
changed the title
Why not just use Levenshtein instead of custom cpp code?
Using Levenshtein C module instead of custom cpp code
Aug 17, 2022
The following line
CharacTER/CharacTER.py
Line 54 in c4b25cb
can be replaced by
If the C extension module is installed (
Levenshtein
) this computation will be blazing fast and compatible with different platforms. Currently, how CharacTER is written with a precompiled SO, this is not the case.Making the change suggested above will lead to better compatibility with close to zero performance loss due to the C implementation in Levenshtein. In fact, the whole
EditDistance
class seems unnecessary as pre_score can be replaced by a single line:I tested this with a large corpus and results were always the same as the current implementation.
The text was updated successfully, but these errors were encountered: