Louvain & Binary Search Random Walk Propagation algorithms crash on some networks

[beka-zhvania]

No description provided.

[MaxKissgen]

Can you maybe provide an example LFR network? We may be able to fix this issue more easily with it

[beka-zhvania]

I was trying to find the reason and I think it might not be a bug and instead the problem was LFR graph being directed (default parameter LFR graph crushed). However it does work on some directed graphs, while crashes on others, but I guess since algorithm is not meant for directed graphs, that doesn't matter.

[MaxKissgen]

Hm, I'll leave this issue open once we can really clarify. We should think about actively prohibiting use of algorithms on graphs of a type they are not compatible with

[beka-zhvania]

Seems the issue was not due to being executed on incompatible graphs. It also seems that it's not just Louvain, but also Binary Search Random Walk Propagation algorithm. Both of them crash on (some) Newman networks e.g. generated with externalEdges = 5

[MaxKissgen]

Could you post one of these example networks as a file? Or does it reliably happen with externalEdges = 5?

[beka-zhvania]

Most graphs I generate with Newman crash for one or both of these algorithms. Maybe there is some error in the algorithm code. I will try to find it. Here is for example a network on which Binary Search Random Walk Propagation crashes. test_graph.txt