Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt if publishing scoped package fails with private error. #16

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Mar 30, 2020

Publishing a scoped package defaults to --access private on the NPM registry for new packages (unless the package has setup a publishConfig property to indicate public access).

This commit detects that specific failure and prompts the user to see if they really meant to publish it as a public package. There is no default value for the confirmation prompt (meaning you must answer either "Yes" or "No") in order to avoid an accidental private information leak.

Publishing a scoped package defaults to `--access private` on the NPM
registry for new packages (unless the package has setup a
`publishConfig` property to indicate public access).

This commit detects that specific failure and prompts the user to see if
they really meant to publish it as a public package. There is no default
value for the confirmation prompt (meaning you **must** answer either
"Yes" or "No") in order to avoid an accidental private information leak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant