Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 Creating files for each test in Ember CLI #3

Closed
WMeldon opened this issue May 23, 2014 · 2 comments
Closed

v0.5.0 Creating files for each test in Ember CLI #3

WMeldon opened this issue May 23, 2014 · 2 comments

Comments

@WMeldon
Copy link
Contributor

WMeldon commented May 23, 2014

The files are supposed to be smashed into one file for tests and one file for app but something is going wrong and I'm ending up with this:
screen shot 2014-05-23 at 1 18 14 pm

Master ECLI only ends up running the JSHint tests for the test files (as they all have the word test in them) and switching back to 0.4.0 fixes it.

Adding v0.5.0 of jshint to v0.0.28 of ECLI causes the issue as well.

I can't really tell if the issue is on this side or if ECLI needs to use this plugin differently due the changes you made.

Edit: Relavent CLI pull: ember-cli/ember-cli#758

@rwjblue
Copy link
Owner

rwjblue commented May 24, 2014

Updated in Ember CLI here: ember-cli/ember-cli#807.

Generating the output in the same location is fundamentally what a broccoli-filter does. The issue here is that it should have been moved afterwards.

@rwjblue rwjblue closed this as completed May 24, 2014
@rwjblue
Copy link
Owner

rwjblue commented May 24, 2014

Thank you for reporting, glad to have this fixed in Ember CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants