Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dark theme icons #32

Open
jakub-g opened this issue Sep 18, 2015 · 2 comments
Open

Provide dark theme icons #32

jakub-g opened this issue Sep 18, 2015 · 2 comments

Comments

@jakub-g
Copy link

jakub-g commented Sep 18, 2015

What do you think about dark theme badges? (&dark=true) Basically replacing black color and gray background with black background and gray text. Would it be easy to implement it?

@rvagg
Copy link
Owner

rvagg commented Sep 19, 2015

Yeah, have a look through: https://github.com/rvagg/nodei.co/blob/master/lib/draw-npm-badge.js

First, all of those rgb() strings would need to be pulled up to consts and then a flag could be provide via the options that come in via the draw() function and be passed to all of the component drawing functions. Would be quite easy but what's the use-case? Where are you putting these badges that warrant this?

@jsejcksn
Copy link

GitHub dark theme is upcoming; it's already in the mobile apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants