Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAN 1.6 #238

Merged
merged 5 commits into from
Jan 23, 2015
Merged

NAN 1.6 #238

merged 5 commits into from
Jan 23, 2015

Conversation

kkoopa
Copy link
Collaborator

@kkoopa kkoopa commented Jan 16, 2015

@kkoopa kkoopa force-pushed the iojs branch 3 times, most recently from 3a4585c to c1b675c Compare January 18, 2015 16:09
@kkoopa
Copy link
Collaborator Author

kkoopa commented Jan 18, 2015

This will not work with node webkit, as they have updated v8, but not indicated it in any detectable way as far as I can see. Too bad.

@rvagg
Copy link
Member

rvagg commented Jan 18, 2015

@rogerwang is there someone in particular we should pull in for this? nw.js could lose solid native addon support if we can't find a resolution to this.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jan 18, 2015

#226 is related for slightly different reasons

@rogerwang
Copy link
Member

I'll help to fix this. What do I need to do in nw.js? defining NODE_MODULE_VERSION to some value?

@rvagg
Copy link
Member

rvagg commented Jan 19, 2015

@kkoopa do we a good have a recommendation here?

@rogerwang if your ABI is the same as some io.js or node release then match the NODE_MODULE_VERSION to that, otherwise make it significantly different. io.js is at 42, atom has jumped to 100. Another alternative is to introduce a new define we can pick up on that talks to your ABI version.

@rogerwang
Copy link
Member

It should be the same as io.js. I'll update the io.js in nw.js, so it will be 42. Currently it's some old version (1.0.0).

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jan 19, 2015

Ah, that would of course explain the mismatch. io.js only bumped NODE_MODULE_VERSION at the last minute before release. Everything should be alright after updating.

@kkoopa kkoopa force-pushed the iojs branch 3 times, most recently from be1e88f to 6b55ed6 Compare January 21, 2015 13:09
kkoopa added a commit that referenced this pull request Jan 23, 2015
@kkoopa kkoopa merged commit d20a030 into master Jan 23, 2015
@Mithgol
Copy link

Mithgol commented Feb 13, 2015

NW.js v0.12.0-alpha3 was released ≈8 hours ago.

Its inner Chromium is updated to 41 beta (41.0.2272.32) and io.js is updated to v1.2.0.

Does that mean nan support?

@kkoopa
Copy link
Collaborator Author

kkoopa commented Feb 13, 2015

I guess so.

On February 13, 2015 5:46:14 PM EET, Mithgol [email protected] wrote:

NW.js v0.12.0-alpha3 was
released
≈8 hours ago.

Its inner Chromium is updated to 41 beta (41.0.2272.32) and io.js
is updated to v1.2.0.

Does that mean nan support?


Reply to this email directly or view it on GitHub:
#238 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants