Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py doesnt specify torch as dependency leading to downstream failures #138

Closed
KukumavMozolo opened this issue Aug 5, 2022 · 4 comments
Labels

Comments

@KukumavMozolo
Copy link

KukumavMozolo commented Aug 5, 2022

Hi there,

is there any chance that you will add torch as a requirement to setup.py or adopt PEP 517?
I am running into problems installing this package while trying to install it using pip-tools as I described here:
jazzband/pip-tools#1662 (comment)

@rusty1s
Copy link
Owner

rusty1s commented Aug 5, 2022

Likely no, since this will result in a lot of issues regarding compilation - if we require torch in setup.py, it will install PyTorch with CUDA 10.2 which might not match your local CUDA version. In addition, you will need to have PyTorch installed in the first place to install this package.

@KukumavMozolo
Copy link
Author

Thank you for your reply,
I am not really knowledgeable on that matter but this https://github.com/huggingface/transformers project also depends on torch and I do not recall running into similar problems installing it via pip-tools.
Maybe there is a solution there?

@rusty1s
Copy link
Owner

rusty1s commented Aug 5, 2022

Well, that‘s because transformers is Python only - it does not need to compile CUDA kernels.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants