Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Deno target available #1117

Merged

Conversation

egfx-notifications
Copy link
Contributor

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

This PR makes Deno available since wasm-bindgen does support it as a target now.
This PR continues the work done in #908. I decided to push the discussed changes here as a separate PR as the original PR creator did not seem to be working on this anymore.

Related PR
#908

Related issues
#672
#879

@egfx-notifications egfx-notifications force-pushed the feature/support-deno-target branch from 068d788 to e084101 Compare March 3, 2022 08:01
@egfx-notifications
Copy link
Contributor Author

Rebased my changes onto v0.10.2 as af8eb33 broke the tests in master.

@egfx-notifications
Copy link
Contributor Author

Have to wait for #1118 to be resolved in order to get the tests to succeed.

@Mipsters
Copy link

Mipsters commented Mar 5, 2022

Thank you for making the effort and continuing the work on adding deno support!

@egfx-notifications egfx-notifications force-pushed the feature/support-deno-target branch from e084101 to dee3614 Compare June 13, 2022 07:38
@egfx-notifications egfx-notifications marked this pull request as ready for review June 13, 2022 07:39
@egfx-notifications
Copy link
Contributor Author

Should be ready for merge now that !1119 was merged

@egfx-notifications egfx-notifications mentioned this pull request Jun 13, 2022
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drager drager merged commit 38a9a41 into rustwasm:master Jun 13, 2022
@egfx-notifications egfx-notifications deleted the feature/support-deno-target branch June 14, 2022 07:37
@drager drager mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants