Revert coverage feature in wasm-bindgen-macro
#4306
Closed
+123
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
edition-2018
branch
from
3637927
to
9525fce
Compare
daxpedda
force-pushed
the
edition-2018
branch
from
e28cf7a
to
86fdfd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-bindgenalways enabled thecoveragecrate feature ofwasm-bindgen-macroif the root crate is edition 2018.Apparently
[target.'cfg(some_flag)'.dependencies]is always triggered regardless of if the flag is set or not when the root crate is edition 2018. A very strange interaction.This PR partly reverts #4284, so now test coverage requires the hack again to pass cfg flags to proc macros.
Fixes #4304.