Don't emit unexpected cfgs in proc-macros #4284
Merged
+61
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
unexpected-cfg-proc-macro
branch
from
79c6457
to
b650488
Compare
daxpedda
force-pushed
the
unexpected-cfg-proc-macro
branch
from
b650488
to
c197908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been caused by recent changes in nightly: rust-lang/rust#132577.
unexpected_cfgis now emitted from proc-macros as well.This PR simply avoids this by checking thecfgcheck in the macro itself, which is required anyway to enable the corresponding unstable features.This changes when the
#[coverage]attribute is emitted by adding an internalcoveragecrate feature to the proc-macro and their utility crates. This crate feature is enabled bywasm-bindgenandwasm-bindgen-testwhencfg(wasm_bindgen_unstable_test_coverage)is enabled.