Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SubmitEvent #2712

Closed
erihsu opened this issue Oct 30, 2021 · 7 comments
Closed

Missing SubmitEvent #2712

erihsu opened this issue Oct 30, 2021 · 7 comments
Labels

Comments

@erihsu
Copy link

erihsu commented Oct 30, 2021

No description provided.

@erihsu erihsu added the bug label Oct 30, 2021
@erihsu erihsu closed this as completed Oct 31, 2021
@finnbear
Copy link

finnbear commented Apr 6, 2022

@erihsu SubmitEvent is missing. Why close the issue?

@erihsu
Copy link
Author

erihsu commented Apr 8, 2022

@finnbear
I close this issue because I found the bindgen exclude all event from raw web api. But submit event can be found in web_sys crate

@prockallsyms
Copy link
Contributor

@erihsu Where may SubmitEvent be found?

@finnbear
Copy link

finnbear commented Jun 1, 2022

@erihsu Where may SubmitEvent be found?

It's a browser API https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent

Could not find in websys though.

My current workaround is an unsafe cast to normal Event, which has the same fields

@prockallsyms
Copy link
Contributor

@finnbear That is what I was wondering as well.
yewstack/yew#2691
I'd be happy to submit a PR to add SubmitEvent to the web_sys crate, but I would like to know if there is a reason it wasn't included to begin with.

@finnbear
Copy link

finnbear commented Jun 1, 2022

but I would like to know if there is a reason it wasn't included to begin with.

I personally have no clue, other than it having the same fields as normal Event, which seemingly reduces motivation to add it. Since the required workaround is unsafe cast, at least to process events in a strongly typed way, I think there is motivation to add it. Maybe ask websys people.

@prockallsyms
Copy link
Contributor

I'll submit a PR to generate discussion on the subject ;)

Thanks for the timely responses! I'll link the PR once I get it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants