Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for controlling svelte dominators output #13

Closed
2 tasks
fitzgen opened this issue Feb 16, 2018 · 1 comment · Fixed by #19
Closed
2 tasks

Add options for controlling svelte dominators output #13

fitzgen opened this issue Feb 16, 2018 · 1 comment · Fixed by #19
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed mentored

Comments

@fitzgen
Copy link
Member

fitzgen commented Feb 16, 2018

  • maximum depth in dominator tree
  • maximum number of rows to include in output, regardless of depth

Each of these involves new fields on the Dominator struct in ./opt/opt.rs.

The DominatorTree struct in analyze/analyze.rs should make and hold a copy of the opt::Dominators options.

Then, the impl traits::Emit for DominatorTree should consult the new options and modify its output appropriately.

@fitzgen
Copy link
Member Author

fitzgen commented Feb 16, 2018

@sendilkumarn, this could be a good issue for you to pick up! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed mentored
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant