Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdraw RUSTSEC-2020-0071: Potential segfault in the time crate #1242

Merged
merged 1 commit into from
May 13, 2022

Conversation

davidkna
Copy link
Contributor

In line with #1241

@tarcieri tarcieri merged commit a47cd63 into rustsec:main May 13, 2022
@tarcieri
Copy link
Member

Thanks!

@davidkna davidkna deleted the withdraw-time branch May 13, 2022 18:28
@jhpratt
Copy link
Contributor

jhpratt commented Jun 2, 2022

As the maintainer of the time crate, this should not have been withdrawn. The affected versions call tzset(), which do in fact mutate the environment. This is also the case for chrono (#1241).

tarcieri added a commit that referenced this pull request Jun 2, 2022
…ate (#1242)"

This reverts commit a47cd63.

The advisory was withdrawn based on discussions around whether read-only
environment variable access constitutes a vulnerability.

However, per the `time` crate's author @jhpratt, the crate also modifies
the environment and therefore the advisory should *not* be withdrawn:

#1242 (comment)
@tarcieri
Copy link
Member

tarcieri commented Jun 2, 2022

I opened #1258 to revert the withdrawal

tarcieri added a commit that referenced this pull request Jun 2, 2022
…ate (#1242)" (#1258)

This reverts commit a47cd63.

The advisory was withdrawn based on discussions around whether read-only
environment variable access constitutes a vulnerability.

However, per the `time` crate's author @jhpratt, the crate also modifies
the environment and therefore the advisory should *not* be withdrawn:

#1242 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants