Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSLKEYLOGFILE #286

Open
pcd1193182 opened this issue Sep 10, 2024 · 3 comments
Open

Add support for SSLKEYLOGFILE #286

pcd1193182 opened this issue Sep 10, 2024 · 3 comments

Comments

@pcd1193182
Copy link

Hey all,

rustls has support for the standard SSL key logging approach (useful when using Wireshark to analyze packet traces. However, hyper-rustls never configures the relevant field. As a result, it is very difficult to debug certain kinds of problems when TLS is in use. Would it be possible to expose this functionality, either by default or through the config builders? Thanks!

@djc
Copy link
Member

djc commented Sep 11, 2024

There is a From<(H, C)> impl for HttpsConnector that should be able to facilitate this use case. If you'd like a more ergonomic solution, we'd be open to a ConfigBuilderExt method for enabling KeyLogFile.

@cpu
Copy link
Member

cpu commented Sep 17, 2024

we'd be open to a ConfigBuilderExt method for enabling KeyLogFile.

@pcd1193182 Would you be interested in writing a PR for this, or is the workaround described above sufficient for your needs?

@pcd1193182
Copy link
Author

Thus far, the workaround is working for me. It would be nice if it was integrated natively into the ConfigBuilderExt, but it's definitely not critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants